[libvirt] [PATCH 1/4] testOpenDefault: Rename loop variable

Michal Privoznik mprivozn at redhat.com
Wed Oct 5 07:30:56 UTC 2016


We have inclination to calling our loop variables i, j, k, not u.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/test/test_driver.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index a382d89..758327c 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -1262,10 +1262,10 @@ testOpenFromFile(virConnectPtr conn, const char *file)
 static int
 testOpenDefault(virConnectPtr conn)
 {
-    int u;
     testDriverPtr privconn = NULL;
     xmlDocPtr doc = NULL;
     xmlXPathContextPtr ctxt = NULL;
+    size_t i;
 
     virMutexLock(&defaultLock);
     if (defaultConnections++) {
@@ -1283,20 +1283,20 @@ testOpenDefault(virConnectPtr conn)
 
     /* Numa setup */
     privconn->numCells = 2;
-    for (u = 0; u < privconn->numCells; ++u) {
-        privconn->cells[u].numCpus = 8;
-        privconn->cells[u].mem = (u + 1) * 2048 * 1024;
-        privconn->cells[u].freeMem = (u + 1) * 1024 * 1024;
+    for (i = 0; i < privconn->numCells; i++) {
+        privconn->cells[i].numCpus = 8;
+        privconn->cells[i].mem = (i + 1) * 2048 * 1024;
+        privconn->cells[i].freeMem = (i + 1) * 1024 * 1024;
     }
-    for (u = 0; u < 16; u++) {
+    for (i = 0; i < 16; i++) {
         virBitmapPtr siblings = virBitmapNew(16);
         if (!siblings)
             goto error;
-        ignore_value(virBitmapSetBit(siblings, u));
-        privconn->cells[u / 8].cpus[(u % 8)].id = u;
-        privconn->cells[u / 8].cpus[(u % 8)].socket_id = u / 8;
-        privconn->cells[u / 8].cpus[(u % 8)].core_id = u % 8;
-        privconn->cells[u / 8].cpus[(u % 8)].siblings = siblings;
+        ignore_value(virBitmapSetBit(siblings, i));
+        privconn->cells[i / 8].cpus[(i % 8)].id = i;
+        privconn->cells[i / 8].cpus[(i % 8)].socket_id = i / 8;
+        privconn->cells[i / 8].cpus[(i % 8)].core_id = i % 8;
+        privconn->cells[i / 8].cpus[(i % 8)].siblings = siblings;
     }
 
     if (!(privconn->caps = testBuildCapabilities(conn)))
-- 
2.8.4




More information about the libvir-list mailing list