[libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser
Julien Grall
julien.grall at arm.com
Wed Oct 5 18:36:52 UTC 2016
Hi Ian,
On 04/10/2016 10:05, Ian Jackson wrote:
> Ian Jackson writes ("[OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser"):
>> Do not grep the virsh capabilities output (!) Instead, parse the XML
>> using perl's XML modules and look for the specific feature flag using
>> an XPATH pattern.
> ...>
>> +sub _check_capability ($$) {
> ...
>> + $rc = $self->check_capability('/capabilities/host/migration_features');
> ^
>
> Missing _. I didn't test this again before sending it. I'd still
> like a review from libvirt (and Xen/ARM) folks.
I am not sure what kind of input you would need from Xen/ARM. This patch
set looks very libvirt specific.
Cheers,
--
Julien Grall
More information about the libvir-list
mailing list