[libvirt] [PATCH v2 17/20] virlog: Remove functions that aren't used anywhere anymore

[Erik Skultety]

On 21/09/16 21:39, John Ferlan wrote:
> 
> 
> On 08/18/2016 07:47 AM, Erik Skultety wrote:
>> This is mainly virLogAddOutputTo* which were replaced by virLogNewOutputTo* and
>> the previously poorly named ones virLogParseAndDefine* functions. All of these
>> are unnecessary now, since all the original callers were transparently switched
>> to the new model of separate parsing and defining logic.
>>
>> Signed-off-by: Erik Skultety <eskultet at redhat.com>
>> ---
>>  src/libvirt_private.syms |   4 -
>>  src/util/virlog.c        | 427 -----------------------------------------------
>>  src/util/virlog.h        |  12 --
>>  3 files changed, 443 deletions(-)
>>
> NOTE:
> 
> My git am -3 failed on this patch:
> 
> Applying: virlog: Remove functions that aren't used anywhere anymore
> fatal: sha1 information is lacking or useless (src/libvirt_private.syms).
> error: could not build fake ancestor
> Patch failed at 0017 virlog: Remove functions that aren't used anywhere
> anymore
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> 
> I'm really not sure why, but I
> 
> NOTE: Existing, but IS_SPACE isn't used either.
> 
> ACK - you could/should remove IS_SPACE separately and use this implied ACK
> 
> John
> 

Thanks, I'll remove it, commit 0b231195 forgot to remove it as part of
the refactor series.

Erik


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161006/74a77329/attachment-0001.sig>