[libvirt] PCP libvirt Plugin

[Michal Privoznik]

On 07.10.2016 09:22, Marko Myllynen wrote:
> Hi,
> 
> On 2016-10-06 15:01, Martin Kletzander wrote:
>> On Wed, Oct 05, 2016 at 07:28:00PM +0300, Marko Myllynen wrote:
>>>
>>> FYI, I've written a PCP plugin (PMDA in PCP parlance) to support most
>>> hypervisor / domain information and metrics available over the libvirt
>>> Python API, it's up to date as of libvirt 2.3 (so it already supports
>>> the recently added perf event metrics).
>>>
>>> The libvirt metrics available with PCP libvirt PMDA and their
>>> descriptions are listed below, they include all the recently added perf
>>> event metrics as well as combined and per-device metrics for each VM.
>>>
>>> I wonder could this be mentioned at https://libvirt.org/apps.html ?
>>
>> Great to hear!  Sure!  Would you mind sending a patch against libvirt's
>> docs/apps.html.in with what you'd like to have mentioned there?  If you
>> don't like doing that I can do that for you, just let me know.
> 
> Sure, how about this?

Almost :-)

> 
> --- a/apps.html
> +++ b/apps.html

this file is generated from the apps.html.in.

> @@ -372,6 +372,12 @@
>          You can use this tool to either set up a new Nagios installation for
>          your Xen or QEMU/KVM guests, or to integrate with your existing Nagios
>          installation.
> +      </dd><dt><a href="http://www.pcp.io/man/man1/pmdalibvirt.1.html" shape="rect">PCP</a></dt><dd>
> +        The PCP libvirt PMDA (plugin) is part of the
> +        <a href="http://pcp.io/" shape="rect">PCP<a> toolkit and provides

s,<a>,</a>,

> +        hypervisor and guest information and complete set of guest performance
> +        metrics. It supports pCPU, vCPU, memory, block device, network interface,
> +        and performance event metrics for each virtual guest.
>        </dd><dt><a href="http://community.zenoss.org/docs/DOC-4687" shape="rect">Zenoss</a></dt><dd>
>          The Zenoss libvirt Zenpack adds support for monitoring virtualization
>          servers.  It has been tested with KVM, QEMU, VMware ESX, and VMware
> 
> Thanks,
> 

I've fixed all of that, came up with a commit message and pushed.

Congratulations on your first libvirt contribution!

Michal