[libvirt] [PATCH 2/3] util: Clear up some perf error messages

John Ferlan jferlan at redhat.com
Fri Oct 7 12:35:36 UTC 2016


Make it clearer that the perf event is based/for the host cpu and
use the virPerfEventTypeToString to convert the type to a string

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/util/virperf.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/util/virperf.c b/src/util/virperf.c
index a65a4bf..6387430 100644
--- a/src/util/virperf.c
+++ b/src/util/virperf.c
@@ -175,7 +175,7 @@ virPerfEventEnable(virPerfPtr perf,
                                        type == VIR_PERF_EVENT_MBMT ||
                                        type == VIR_PERF_EVENT_MBML)) {
         virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
-                       _("unable to enable perf event for %s"),
+                       _("unable to enable host cpu perf event for %s"),
                        virPerfEventTypeToString(event->type));
         return -1;
     }
@@ -205,14 +205,14 @@ virPerfEventEnable(virPerfPtr perf,
     event->fd = syscall(__NR_perf_event_open, &attr, pid, -1, -1, 0);
     if (event->fd < 0) {
         virReportSystemError(errno,
-                             _("Unable to open perf event for %s"),
+                             _("unable to open host cpu perf event for %s"),
                              virPerfEventTypeToString(event->type));
         goto error;
     }
 
     if (ioctl(event->fd, PERF_EVENT_IOC_ENABLE) < 0) {
         virReportSystemError(errno,
-                             _("Unable to enable perf event for %s"),
+                             _("unable to enable host cpu perf event for %s"),
                              virPerfEventTypeToString(event->type));
         goto error;
     }
@@ -236,8 +236,8 @@ virPerfEventDisable(virPerfPtr perf,
 
     if (ioctl(event->fd, PERF_EVENT_IOC_DISABLE) < 0) {
         virReportSystemError(errno,
-                             _("Unable to disable perf event type=%d"),
-                             event->type);
+                             _("unable to disable host cpu perf event for %s"),
+                             virPerfEventTypeToString(event->type));
         return -1;
     }
 
-- 
2.7.4




More information about the libvir-list mailing list