[libvirt] [PATCH] virsh: vol-resize: be explicit that this is an offline operation.

[Martin Kletzander]

On Tue, Oct 11, 2016 at 05:13:57PM -0300, Ivan Baldo wrote:
>No time to read manpages at home heheh (qemu-img check -r all repaired it very well though).

If you have just a note that's not supposed to be part of the commit
message, you can put it after

>---

^^^  these and it will be part of the email, but git will not include it
in the commit message.

I'm glad qemu-img check fixed it for you, I did the similar thing some
time ago, but I guess I was lucky as everything worked nicely.  I didn't
know about blockresize, too.

> tools/virsh-volume.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c
>index f302f95..46c36c2 100644
>--- a/tools/virsh-volume.c
>+++ b/tools/virsh-volume.c
>@@ -1050,7 +1050,7 @@ static const vshCmdInfo info_vol_resize[] = {
>      .data = N_("resize a vol")
>     },
>     {.name = "desc",
>-     .data = N_("Resizes a storage volume.")
>+     .data = N_("Resizes a storage volume offline (only safe if not in use).")

It is mentioned in the man page already, so we can make the text
slightly similar to that (so that it at least feels consistent), also I
thing the hint for using blockresize could help here.

So I adjusted the text, expanded on that commit message and will push it
in a while.

Congratulations on your first contribution ;)

Have a nice day,
Martin

>     },
>     {.name = NULL}
> };
>--
>2.1.4
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161013/72a8cd02/attachment-0001.sig>