[libvirt] [PATCH v2 10/14] qemuBuildVhostuserCommandLine: Reuse qemuBuildChrChardevStr

John Ferlan jferlan at redhat.com
Thu Oct 13 14:59:40 UTC 2016



On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> There's no need to reinvent the wheel here. We already have a
> function to format virDomainChrSourceDefPtr. It's called
> qemuBuildChrChardevStr(). Use that instead of some dummy
> virBufferAsprintf().
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_command.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 

If someone bisected to here, they'd have issues because patch 11 needs
to be merged here...

ACK if merged with patch 11

John




More information about the libvir-list mailing list