[libvirt] [PATCH v2 12/14] qemuBuildVhostuserCommandLine: Unify -netdev creation

John Ferlan jferlan at redhat.com
Thu Oct 13 15:00:02 UTC 2016



On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> Currently, what we do for vhost-user network is generate the
> following part of command line:
> 
> -netdev type=vhost-user,id=hostnet0,chardev=charnet0
> 
> There's no need for 'type=' it is the default. Drop it.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_command.c                                       | 2 +-
>  tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser-multiq.args | 6 +++---
>  tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.args        | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 

Still an ACK,

John




More information about the libvir-list mailing list