[libvirt] [PATCH v3 17/18] qemu: add a USB3 controller to Q35 domains by default

Andrea Bolognani abologna at redhat.com
Thu Oct 13 16:46:29 UTC 2016


On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote:
> Previously we added a set of EHCI+UHCI controllers to Q35 machines to
> mimic real hardware as closely as possible, but recent discussions
> have pointed out that the nec-usb-xhci (USB3) controller is much more
> virtualization-friendly (uses less CPU), so this patch switches the
> default for Q35 machinetypes to add an XHCI instead (if it's
> supported, which it of course *will* be).
> 
> Since none of the existing test cases left out USB controllers in the
> input XML, a new Q35 test case was added which has *no* devices, so
> ends up with only the defaults always put in by qemu, plus those added
> by libvirt.
> ---
>  src/qemu/qemu_domain.c                             | 10 ++++--
>  .../qemuxml2argv-q35-default-devices-only.args     | 22 ++++++++++++
>  .../qemuxml2argv-q35-default-devices-only.xml      | 18 ++++++++++
>  tests/qemuxml2argvtest.c                           | 22 ++++++++++++
>  .../qemuxml2xmlout-q35-default-devices-only.xml    | 40 ++++++++++++++++++++++
>  tests/qemuxml2xmltest.c                            | 22 ++++++++++++
>  6 files changed, 131 insertions(+), 3 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-default-devices-only.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-default-devices-only.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-default-devices-only.xml

ACK

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list