[libvirt] [PATCH] util: Fix build on s390

Paul Eggert eggert at cs.ucla.edu
Thu Oct 13 21:13:53 UTC 2016


On 10/13/2016 12:14 PM, Eric Blake wrote:
> I think a configure test based on -Werror=format would be
> sufficient

What we have now should work for GCC 2.0 and later, whereas 
-Werror=format is a much-newer GCC feature and so would be less portable.

> if they are using some other compiler,
> then chances are -Wformat does not work, therefore the problem cannot be
> portably observed so there is nothing to work around

I am worried that other compilers might warn about it even without 
-Werror=format. (I'm not worried about GCC, as nobody uses GCC 1 any more.)




More information about the libvir-list mailing list