[libvirt] [PATCH v2] qemu: report block job errors from qemu to the user

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Fri Oct 14 09:12:49 UTC 2016


So that you can see nice report on migration:

"error: operation failed: migration of disk sda failed: No space left on device"

diff from v1:
1. drop 1 patch. Avoiding default label in switches is desired style.
2. drop 2 patch. I do not investigate enough to touch that place.
3. fix 3 patch 
  a) as suggested by Jiri
    * fix leaks
    * s/hint/error/g
    * don't show <NULL> in error message
    * take suggested code simplifications
  b) extra
    * print error string from qemu to log in case we have to drop it

Nikolay Shirokovskiy (1):
  qemu: report block job errors from qemu to the user

 src/qemu/qemu_blockjob.c     | 13 +++++++++--
 src/qemu/qemu_blockjob.h     |  3 ++-
 src/qemu/qemu_domain.c       |  1 +
 src/qemu/qemu_domain.h       |  1 +
 src/qemu/qemu_driver.c       |  4 ++--
 src/qemu/qemu_migration.c    | 54 +++++++++++++++++++++++++++++++-------------
 src/qemu/qemu_monitor.c      |  5 ++--
 src/qemu/qemu_monitor.h      |  4 +++-
 src/qemu/qemu_monitor_json.c |  4 +++-
 src/qemu/qemu_process.c      |  4 ++++
 10 files changed, 68 insertions(+), 25 deletions(-)

-- 
1.8.3.1




More information about the libvir-list mailing list