[libvirt] [PATCH] cpu_conf: add comments about sockets in cpu_conf

Peter Krempa pkrempa at redhat.com
Tue Oct 18 13:59:44 UTC 2016


On Tue, Oct 18, 2016 at 16:18:10 +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at gmail.com>
> 
> 'sockets' in output of `virsh capabilities' means

You are talking here about virsh capabilities, while the code is about
the cpu definition in the domain configuration.

> the sockets per NUMA node,
> which is a special case.

Indeed it is a special case in the capabilities XML. So why are you
changing the code relevant to domain definition, where the sockets
count is actually the total sockets count?

> discuss in:
> https://www.redhat.com/archives/libvir-list/2012-March/msg01123.html

https://www.redhat.com/archives/libvir-list/2012-March/msg01133.html
describes why sockets per NUMA node is not really what we want.

> Signed-off-by: Chen Hanxiao <chenhanxiao at gmail.com>
> ---
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161018/c37051c4/attachment-0001.sig>


More information about the libvir-list mailing list