[libvirt] [PATCH 1/2] qemu_command: create prefixed alias to separate variable

Pavel Hrdina phrdina at redhat.com
Tue Oct 18 14:31:46 UTC 2016


On Tue, Oct 18, 2016 at 10:22:50AM -0400, John Ferlan wrote:
> 
> 
> On 10/18/2016 09:58 AM, Pavel Hrdina wrote:
> > Instead of typing the prefix every time we want to append parameters
> > to qemu command line use a variable that contains prefixed alias.
> > 
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> >  src/qemu/qemu_command.c | 35 ++++++++++++++++++++---------------
> >  1 file changed, 20 insertions(+), 15 deletions(-)
> > 
> 
> Why not create a qemu_alias.c helper that then can also be used in your
> followup patch?

That's a good point, I did not realize that we have qemu_alias.c.

I'll send v2, thanks.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161018/e598f806/attachment-0001.sig>


More information about the libvir-list mailing list