[libvirt] [PATCH v2 2/2] libssh_transport: add new libssh-based transport

[Pino Toscano]

On Tuesday, 18 October 2016 15:49:56 CEST Daniel P. Berrange wrote:
> On Tue, Oct 18, 2016 at 04:46:53PM +0200, Pino Toscano wrote:
> > On Tuesday, 18 October 2016 14:19:41 CEST Daniel P. Berrange wrote:
> > > On Mon, Oct 17, 2016 at 04:24:53PM +0200, Pino Toscano wrote:
> > > > Implement a new libssh transport, which uses libssh to communicate with
> > > > remote hosts, and use it in virNetSockets.
> > > > 
> > > > This new transport supports all the common ssh authentication methods,
> > > > making use of libvirt's auth callbacks for interaction with the user.
> > > > 
> > > > Most of the functionalities and implementation are based on the libssh2
> > > > transport.
> > > > ---
> > > >  config-post.h                 |    2 +
> > > >  configure.ac                  |    3 +
> > > >  include/libvirt/virterror.h   |    2 +
> > > >  m4/virt-libssh.m4             |   26 +
> > > >  src/Makefile.am               |   21 +-
> > > >  src/libvirt_libssh.syms       |   22 +
> > > >  src/remote/remote_driver.c    |   41 ++
> > > >  src/rpc/virnetclient.c        |  123 ++++
> > > >  src/rpc/virnetclient.h        |   13 +
> > > >  src/rpc/virnetlibsshsession.c | 1424 +++++++++++++++++++++++++++++++++++++++++
> > > >  src/rpc/virnetlibsshsession.h |   80 +++
> > > >  src/rpc/virnetsocket.c        |  179 ++++++
> > > >  src/rpc/virnetsocket.h        |   13 +
> > > >  src/util/virerror.c           |    9 +-
> > > >  14 files changed, 1955 insertions(+), 3 deletions(-)
> > > >  create mode 100644 m4/virt-libssh.m4
> > > >  create mode 100644 src/libvirt_libssh.syms
> > > >  create mode 100644 src/rpc/virnetlibsshsession.c
> > > >  create mode 100644 src/rpc/virnetlibsshsession.h
> > > 
> > > libvirt.spec.in and mingw-libvirt.spec.in need updating too, as well
> > > as docs/remote.html.in
> > 
> > OK for libvirt.spec.in and docs/remote.html.in, but libssh for mingw is
> > not available in Fedora.
> 
> Is it possible to build libssh for mingw ?  If so we'll need to look at
> getting that into Fedora.

I don't know -- I can request that to its maintainer once the libssh
transport is in (so there is an actual use case for adding mingw
support).

At least, libssh is supposed to build and work on Windows as well.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161019/3d173033/attachment-0001.sig>