[libvirt] [PATCH] libxl: fix leaking of allocated migration ports

[Pavel Hrdina]

On Fri, Oct 14, 2016 at 12:19:19PM -0600, Jim Fehlig wrote:
> Although the migration port is immediately released in the
> finish phase of migration, it was never set in the domain
> private object when allocated in the prepare phase. So
> libxlDomainMigrationFinish() always released a 0-initialized
> migrationPort, leaking any allocated port. After enough
> migrations to exhaust the migration port pool, migration would
> fail with
> 
> error: internal error: Unable to find an unused port in range
>        'migration' (49152-49216)
> 
> Fix it by setting libxlDomainObjPrivate->migrationPort to the
> port allocated in the prepare phase. While at it, also fix
> leaking an allocated port if the prepare phase fails.
> 
> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
> ---

ACK

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161021/06702d9c/attachment-0001.sig>