[libvirt] [PATCH 0/3] Alter 'source' to be virDomainChrSourceDefPtr in _virDomainChrDef

John Ferlan jferlan at redhat.com
Fri Oct 21 13:01:41 UTC 2016


Yes, it's absolutely terrifying; however, in order to "fix" problems noted
during the review of the TLS chardev TCP 'properly' making the 'source' be
a pointer and then moving the 'privateData' from _virDomainChrDef to
_virDomainChrSourceDef will allow for setting of the 'secinfo' for the
smartcard, rng, and redirdev backends that use a TCP channel.

95% of the changes obviously fell out of build issues from a 'make check
syntax-check'. The remaining 5% of the changes are from sources I don't
normally build; however, those were found by using cscope on the sources
and finding references of "source\.{type|data|logfile|logappend} (IOW:
virDomainChrSourceDef members).

John Ferlan (3):
  vmx: Use the allocator virDomainChrDefNew
  Introduce virDomainChrSourceDefNew for virDomainChrDefPtr
  conf: Move the privateData from virDomainChrDef to
    virDomainChrSourceDef

 src/bhyve/bhyve_command.c        |  8 ++---
 src/bhyve/bhyve_driver.c         |  2 +-
 src/bhyve/bhyve_parse_command.c  | 20 +++++------
 src/conf/domain_audit.c          |  4 +--
 src/conf/domain_conf.c           | 53 +++++++++++++++++----------
 src/conf/domain_conf.h           |  4 +--
 src/libxl/libxl_conf.c           | 42 +++++++++++-----------
 src/libxl/libxl_domain.c         | 22 ++++++------
 src/libxl/libxl_driver.c         |  4 +--
 src/lxc/lxc_driver.c             |  4 +--
 src/lxc/lxc_native.c             |  2 +-
 src/lxc/lxc_process.c            |  6 ++--
 src/qemu/qemu_cgroup.c           |  2 +-
 src/qemu/qemu_command.c          | 28 +++++++--------
 src/qemu/qemu_domain.c           | 16 ++++-----
 src/qemu/qemu_driver.c           |  8 ++---
 src/qemu/qemu_hotplug.c          |  6 ++--
 src/qemu/qemu_parse_command.c    |  4 +--
 src/qemu/qemu_process.c          | 28 +++++++--------
 src/security/security_dac.c      |  4 +--
 src/security/security_selinux.c  |  4 +--
 src/security/virt-aa-helper.c    | 70 ++++++++++++++++++------------------
 src/uml/uml_conf.c               | 14 ++++----
 src/uml/uml_driver.c             | 12 +++----
 src/vbox/vbox_common.c           | 46 ++++++++++++------------
 src/vmx/vmx.c                    | 78 ++++++++++++++++++++--------------------
 src/vz/vz_sdk.c                  | 78 ++++++++++++++++++++--------------------
 src/xen/xen_driver.c             |  4 +--
 src/xenconfig/xen_sxpr.c         | 76 +++++++++++++++++++--------------------
 src/xenconfig/xen_xl.c           | 14 ++++----
 tests/securityselinuxlabeltest.c | 14 ++++----
 31 files changed, 346 insertions(+), 331 deletions(-)

-- 
2.7.4




More information about the libvir-list mailing list