[libvirt] [PATCH 3/3] domain: fix migration to older libvirt

[John Ferlan]

On 10/24/2016 10:28 AM, Pavel Hrdina wrote:
> On Mon, Oct 24, 2016 at 10:11:53AM -0400, John Ferlan wrote:
>>
>>
>> On 10/24/2016 08:41 AM, Pavel Hrdina wrote:
>>> Since TLS feature was introduced in libvirt 2.3.0 we have to modify
>>
>> Since TLS was introduced hostwide for libvirt 2.3.0 and a domain
>> configurable haveTLS was implemented for libvirt 2.4.0, we have to
>> modify the
>>
>>> migratable XML for specific case where 'tls' attribute is based on
>>
>> s/where/where the/
>>
>>> setting from qemu.conf.
>>>
>>> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>>> ---
>>>  src/conf/domain_conf.c | 24 +++++++++++++++++++++++-
>>>  src/conf/domain_conf.h |  1 +
>>>  src/qemu/qemu_domain.c |  1 +
>>>  3 files changed, 25 insertions(+), 1 deletion(-)
>>>
>>
>>
>> TBH this is ultimately very odd/confusing to read.  The "tlsFromConfig"
>> doesn't end up in the config XML right?  Just the migratable.
> 
> The "tlsFromConfig" is libvirt internal attribute and is stored only in
> status XML to ensure that when libvirtd is restarted this internal flag is
> not lost by the restart.
> 
> That flag is used to decide whether we should put *tls* attribute to
> migratable XML or not.  I'll add it to the commit message to make it clear.
> 
> I'll wait with pushing for your reply.

That's fine -

John

> 
> Pavel
> 
>> ACK since you've shown in the previous series that the permutations
>> work. Perhaps an extra word or two in the commit message regarding the
>> flag and how it's used will be helpful for the person who reads the code
>> once we've both (shortly) forgotten about it
>>
>> John
>>
[...]