[libvirt] [PATCH 0/5] wireshark: Fix $(prefix) handling

Andrea Bolognani abologna at redhat.com
Wed Oct 26 16:10:56 UTC 2016


On Wed, 2016-10-26 at 16:54 +0200, Michal Privoznik wrote:
> On 26.10.2016 15:27, Andrea Bolognani wrote:
>> > Well, almost :) There are still some cases that are not
> > handled correctly, but at least this will unbreak 'make
> > rpm' while I work on the rest.
>> > Tested by running 'make rpm' successfully on Fedora 23,
> > Fedora 24 and Fedora rawhide.
>>> > Andrea Bolognani (5):
> >   wireshark: Introduce $ws_modversion
> >   wireshark: Hoist $ws_prefix declaration
> >   wireshark: Strip prefix correctly
> >   wireshark: Inject $(prefix) at the right time
> >   wireshark: Rename plugindir to ws_plugindir
>> >  m4/virt-wireshark.m4 | 29 ++++++++++++++++++-----------
> >  tools/Makefile.am    |  2 +-
> >  2 files changed, 19 insertions(+), 12 deletions(-)
> 
> ACK series. Thanks for cleaning up my mess.

Don't mention it, it was fun :)

On the other hand, if you really want to thank me, I guess
taking a look at the follow-up series

  https://www.redhat.com/archives/libvir-list/2016-October/msg01187.html

would be as good a way as any :P

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list