[libvirt] [PATCH v3] Fixes virsh save-restore/migration when memory detach not in LIFO

[Peter Krempa]

On Fri, Oct 14, 2016 at 08:35:16 -0400, John Ferlan wrote:
> 
> 
> On 10/04/2016 09:06 AM, Nitesh Konkar wrote:
> > Currently the migration stream references the memory
> > blocks by name (which is supplied by libvirt) rather
> > than by there order. With the current code that is
> > assigning aliases for memory backend objects this
> > won't happen and since qemu is treating the memory
> > object links differently migration does not work in
> > such case.
> > 
> > This patch ensures slot number alocation for the memory
> 
> allocation
> 
> > modules beforehand and assign alias accordingly. This
> > keeps slot numbers consistent with the aliases always.
> > 
> > Signed-off-by: Nitesh Konkar <nitkon12 at linux.vnet.ibm.com>
> > ---
> >  src/conf/domain_conf.h  |  1 +
> >  src/qemu/qemu_alias.c   | 36 +++++++++++++++++++++++++-----------
> >  src/qemu/qemu_alias.h   |  6 ++++--
> >  src/qemu/qemu_domain.c  |  3 +++
> >  src/qemu/qemu_hotplug.c |  5 ++++-
> >  5 files changed, 37 insertions(+), 14 deletions(-)
> > 
> 
> I believe Peter's review of your v2 mentioned a few other things... In
> particular test cases... but also a subtle point about partial manual
> assignment of slots by a user which I'm not sure you covered in the new
> AssignSlot method below.

Also as I've already pointed out. I'm about to fix the issue. I've
already have some patches but I was on vacation and thus did not manage
to post them.

Peter