[libvirt] [PATCH] vsh: Pass correct values for command line completion

[Erik Skultety]

On Fri, Oct 28, 2016 at 05:09:38PM -0400, John Ferlan wrote:
> Commit id 'dcfdf341' passes 'opts_need_arg' and 'opts_seen' to
> vshCmddefGetData, but that seems to be incorrect as those values
> are not initialized properly (something at least one compiler found).
> Instead the static 'const_opts_need_arg' and 'const_opts_seen' values
> should be passed.
> 
> By passing unitialized values leads to not finding possible options
> for simpler commands (domfsfreeze for example), where if you're in
> a virsh shell using command line completion - you'll get a list of
> files in your current directory instead of two options --domain and
> --mountpoint (as would happen with this patch applied.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  tools/vsh.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

ACK

Erik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161031/12492fe8/attachment-0001.sig>