[libvirt] [PATCH v2 3/3] qemu: Implement virtio-net rx_queue_size

[Martin Kletzander]

On Wed, Aug 31, 2016 at 05:10:35PM +0200, Michal Privoznik wrote:
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_command.c                            |  8 +++++++
> .../qemuxml2argv-net-virtio-rxqueuesize.args       | 25 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c                           |  2 ++
> 3 files changed, 35 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-virtio-rxqueuesize.args
>
>diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>index 982c33c..fce779b 100644
>--- a/src/qemu/qemu_command.c
>+++ b/src/qemu/qemu_command.c
>@@ -3553,6 +3553,14 @@ qemuBuildNicDevStr(virDomainDefPtr def,
>             virBufferAsprintf(&buf, ",mq=on,vectors=%zu", 2 * vhostfdSize + 2);
>         }
>     }
>+    if (usingVirtio && net->driver.virtio.rx_queue_size) {

I kinda hate that we blindly go on if it's not virtio device, so that
users might thing they increased the ring size but actually we just skip
using that tunable at all.  But since we do that with, literally, all
the other tunables...

ACK series (when it is pushed in QEMU, which it looks like it's queued
for after the release)

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160901/a76ecb51/attachment-0001.sig>