[libvirt] [PATCH v3 1/4] libxl: support serial list

[Jim Fehlig]

On 08/31/2016 08:36 PM, Jim Fehlig wrote:
> On 08/17/2016 08:20 PM, Bob Liu wrote:
>> Add support for multi serial devices, after this patch virsh can be used to
>> connect different serial devices of running domains. E.g.
>> vish # console <xxx> --devname serial<xxx>
>>
>> Note:
>> This depends on a xen/libxl bug fix to have libxl_console_get_tty(...) correctly
>> returning the tty path (as opposed to always returning the first one).
>> [0] https://lists.xen.org/archives/html/xen-devel/2016-08/msg00438.html
>>
>> Signed-off-by: Bob Liu <bob.liu at oracle.com>
>> ---
>> v3: Comments from Jim.
>> v2: Add #ifdef LIBXL_HAVE_BUILDINFO_SERIAL_LIST.
> Not that it matters much, but I guess this is actually V4 since Joao had a
> review comment on V3 :-).
>
> With the exception of a small nit in patch 2, which I've already fixed in my
> branch, V4 looks good to me and works fine in my testing - ACK. But we'll have
> to wait until 2.2.0 is released before pushing. Thanks for your patience!

Pushed now that the release is out.

Regards,
Jim