[libvirt] [PATCH v2 0/3] virsh: Option completers and small improvements/fixes for autocomplete

Michal Privoznik mprivozn at redhat.com
Mon Sep 5 14:45:41 UTC 2016


On 05.09.2016 11:45, Nishith Shah wrote:
> This series introduces option completers and adds some minor improvements
> and fixes(not bugs per se, just better/sane behavior) in vshReadlineParse.
> 
> The first patch introduces the usage of option completers to auto-complete
> arguments for a particular option.
> 
> The second and third patches provide small improvements like completing
> the options of type VSH_OT_ARGV or VSH_OT_DATA, and to complete multiple
> options as well, if a previous option requires an argument, and that
> argument has been provided.
> 
> ---
> v2: Fix an infinite while loop bug
> 
> v1: https://www.redhat.com/archives/libvir-list/2016-August/msg01009.html
> 
> Nishith Shah (3):
>   virsh: Introduce usage of option completers to auto-complete arguments
>   virsh: Allow data or argument options to be completed as well
>   virsh: Complete multiple options when any one option requires data
> 
>  tools/vsh.c | 75 ++++++++++++++++++++++++++++++++++++++++---------------------
>  1 file changed, 49 insertions(+), 26 deletions(-)
> 

ACKed and pushed. Thanks for fixing that bug.

Michal




More information about the libvir-list mailing list