[libvirt] [PATCH] virsh: Fix *-event error string

Christophe Fergeau cfergeau at redhat.com
Tue Sep 6 14:41:46 UTC 2016


On Tue, Sep 06, 2016 at 03:07:37PM +0200, Erik Skultety wrote:
> ACK, although, I have a really small nitpick the decision on fixing of
> which I leave to you. After the fix, "--list or --event type...", at
> least to me, sounds like "--event" was the mentioned type itself which
> is of course wrong. Maybe it could be better (just an idea) to use angle
> brackets like this '<type>' to make the message more clear, but as I
> said, your call.

I considered doing it, but did not for no particular reason. I'll change
it before pushing.

Thanks,

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160906/b0defef2/attachment-0001.sig>


More information about the libvir-list mailing list