[libvirt] [PATCH] qemu_driver: protect existed save image

Peter Krempa pkrempa at redhat.com
Wed Sep 7 16:00:03 UTC 2016


On Thu, Aug 18, 2016 at 19:47:29 +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at gmail.com>
> 
> We may overwrite existed save image by
> 'virsh save' command.
> 
> This patch will check qemu save headers
> before trying to rewrite it.

I think overwriting a file is a valid use case.

If we'd want to fix it we should forbid overwriting ANY files not just
existing files created by libvirt.

NACK




More information about the libvir-list mailing list