[libvirt] [libvirt-php][PATCH 1/8] libvirt_domain_get_network_info: Don't overwrite retval

Michal Privoznik mprivozn at redhat.com
Thu Sep 8 07:56:28 UTC 2016


In e0d6f457 I've tried to fix a memleak. However, in
libvirt_domain_get_network_info instead of plain 'return' I've
put 'RETURN_TRUE'. This macro throws away whatever return value
we've constructed so far and replace it with integer value of 1.
Le sigh.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/libvirt-php.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libvirt-php.c b/src/libvirt-php.c
index 57ef1a0..33b4c5d 100644
--- a/src/libvirt-php.c
+++ b/src/libvirt-php.c
@@ -7181,7 +7181,7 @@ PHP_FUNCTION(libvirt_domain_get_network_info)
     free(xml);
     free(xpath);
     free(tmp);
-    RETURN_TRUE;
+    return;
 
  error:
     free(xml);
-- 
2.8.4




More information about the libvir-list mailing list