[libvirt] [PATCH] usb: allow host devices to be specified by port

Cole Robinson crobinso at redhat.com
Thu Sep 8 20:45:22 UTC 2016


Thanks for the patch. Sorry this didn't get a timely response. Note there's an
upstream bug for this as well but it doesn't add much:

https://bugzilla.redhat.com/show_bug.cgi?id=914883

The patch is a bit difficult to review because it's mixing up some
refactorings in virhostdev.c with the functional additions. Please separate
the refactoring and submit it separately, before the functional changes.

Also missing is docs/formatdomain.html.in extension, which can go in the patch
with the functional changes. We can help with that though if you don't want to
wade into editing XML.

On 07/05/2016 05:21 PM, Thomas Hebb wrote:
> Previously, only VID/PID and bus/device matching were supported. Neither
> of these provide a stable and persistent way of assigning a guest a
> specific host device out of several with the same VID and PID, as device
> numbers change on every enumeration.
> 
> Add a third method of matching, bus/port, which allows a specific port on
> the host to be specified using the dotted notation found in Linux's
> "devpath" sysfs attribute.

Is there any way to determine the host port outside of checking sysfs? Some
'lsusb' switch that makes this easy to lookup?

Thanks,
Cole




More information about the libvir-list mailing list