[libvirt] [PATCH] util: Quiet the logging if perf file doesn't exist
Michal Privoznik
mprivozn at redhat.com
Mon Sep 12 08:49:13 UTC 2016
On 07.09.2016 00:00, John Ferlan wrote:
> Commit id 'b00d7f29' shifted the opening of the /sys/devices/intel_cqm/type
> file from event enable to perf event initialization. If the file did not
> exist, then an error would be written to the domain log:
>
> 2016-09-06 20:51:21.677+0000: 7310: error : virFileReadAll:1360 : Failed to open file '/sys/devices/intel_cqm/type': No such file or directory
>
> Since the error is now handled in virPerfEventEnable by checking if the
> event_attr->attrType == 0 for CMT, MBML, and MBMT events - we can just
> use the Quiet API in order to not log the error we're going to throw away.
>
> Additionally, rather than using virReportSystemError, use virReportError
> and VIR_ERR_ARGUMENT_UNSUPPORTED in order to signify that support isn't there
> for that type of perf event - adjust the error message as well.
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> src/util/virperf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
ACK
Michal
More information about the libvir-list
mailing list