[libvirt] [PATCH 0/2] A couple of volume encryption patches

[Michal Privoznik]

On 06.09.2016 23:16, John Ferlan wrote:
> I'm assume there will be a couple of bz's on these...
> 
> Patch 1 fixes a problem where the vol-dumpxml would not list the <secret>
> element from a volume in a pool after the initial creation and a pool
> refresh (or libvirtd restart). This issue was missed due to rewriting
> the LUKS support to not use it's own "new" secret type (key), but rather
> use the existing "volume" secret type.
> 
> Patch 2 fixes a problem where QCOW2 (or QCOW1) encrypted volume would
> lose the <encryption> and <secret> after a volume refresh. Details are
> in the patch. The issue is rooted in proper detection of the volume type
> during the virStorageFileGetMetadataFromBuf call.
> 
> John Ferlan (2):
>   storage: Need to refresh secret for luks volume after volume refresh
>   storage: Need to properly read the crypt offset value
> 
>  src/storage/storage_backend_fs.c | 16 ++++++++++------
>  src/util/virstoragefile.c        |  7 +++++--
>  2 files changed, 15 insertions(+), 8 deletions(-)
> 

ACK to both.

Michal