[libvirt] [PATCH] qemu: Don't use query-migrate on destination

[Pavel Hrdina]

On Mon, Sep 12, 2016 at 12:48:28PM +0200, Jiri Denemark wrote:
> When migration fails, we need to poke QEMU monitor to check for a reason
> of the failure. We did this using query-migrate QMP command, which is
> not supposed to return any meaningful result on the destination side.
> Thus if the monitor was still functional when we detected the migration
> failure, parsing the answer from query-migrate always failed with the
> following error message:
> 
>     "info migration reply was missing return status"
> 
> This irrelevant message was then used as the reason for the migration
> failure replacing any message we might have had.
> 
> Let's use harmless query-status for poking the monitor to make sure we
> only get an error if the monitor connection is broken.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1374613
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_domain.c    | 20 ++++++++++++++++++++
>  src/qemu/qemu_domain.h    |  4 ++++
>  src/qemu/qemu_migration.c |  6 +-----
>  src/qemu/qemu_monitor.c   |  8 ++++++++
>  src/qemu/qemu_monitor.h   |  1 +
>  5 files changed, 34 insertions(+), 5 deletions(-)

ACK

Pavel