[libvirt] [PATCH 2/2] virDomainGetBlockJobInfo: Fix corner case when qemu reports no info

John Ferlan jferlan at redhat.com
Mon Sep 12 18:01:32 UTC 2016


[...]

>>
>> Can info->ready == 0 ?  w/ info->cur = info->end = 0
>>
>> If so, then we're in the same mess or some other weird condition.
>>
>> Seems like "ready" will be set in qemu during block_job_event_ready, so
>> that would say to me that as long as the structure is allocated, ready
>> will be false and conceivably info->cur = info->end = 0.
>>
>> Wouldn't that mean the < 0 should be <= 0
> 
> Okay, better safe than sorry; this looks reasonable to me. I mean, it
> looks unlikely to me that qemu will already allocate its internal job
> structure without filling @cur and @end, but it is possible, so I can do
> the change.
> 
> Do you want me to send v2?
> 

Not necessary...

John




More information about the libvir-list mailing list