[libvirt] [PATCH 1/2] util: numa: Remove impossible error handling

Peter Krempa pkrempa at redhat.com
Tue Sep 13 15:08:03 UTC 2016


The code guarantees that virBitmapSetBit won't be called with out of
range values. Just ignore the return value and remove dead error
handling.
---
 src/util/virnuma.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/util/virnuma.c b/src/util/virnuma.c
index fc25051..c4d11fa 100644
--- a/src/util/virnuma.c
+++ b/src/util/virnuma.c
@@ -1004,12 +1004,7 @@ virNumaGetHostNodeset(void)
         if (!virNumaNodeIsAvailable(i))
             continue;

-        if (virBitmapSetBit(nodeset, i) < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                           _("Problem setting bit in bitmap"));
-            virBitmapFree(nodeset);
-            return NULL;
-        }
+        ignore_value(virBitmapSetBit(nodeset, i));
     }

     return nodeset;
-- 
2.10.0




More information about the libvir-list mailing list