[libvirt] [PATCH v2 0/3] Introduce aliases for virt-admin's srv-* commands

Erik Skultety eskultet at redhat.com
Wed Sep 14 07:40:49 UTC 2016


On 13/09/16 17:11, Erik Skultety wrote:
> the original version:
> https://www.redhat.com/archives/libvir-list/2016-September/msg00312.html
> 
> since v1:
>     - tweaked the virsh-self-test so that it also checks the aliased commands
>     instead of skipping them (since there was a good reason for that before the
>     changes this series introduces)
>     - patches 2-3 remained untouched
> 
> Erik Skultety (3):
>   virt-admin: Tweak command parsing logic so that aliases point to new
>     commands
>   virt-admin: Add some command aliases to provide syntax sugar over ugly
>     commands
>   virt-admin: Replace the (now) aliases with new command names in the
>     man page
> 
>  tools/virsh-nodedev.c |  6 ++----
>  tools/virsh.c         | 10 ++++++----
>  tools/virsh.pod       |  2 --
>  tools/virt-admin.c    | 24 ++++++++++++++++++++++++
>  tools/virt-admin.pod  | 30 +++++++++++++++---------------
>  tools/vsh.c           |  6 ++++++
>  tools/vsh.h           |  1 +
>  7 files changed, 54 insertions(+), 25 deletions(-)
> 

SNACK. Having an error like "internal error: bad command options" would
be nice indeed - thanks Michal [1] - which could be achieved by a tiny
refactor, also fixing a semantically incorrect check that can cause a
segfault on missing '.info' as well, pretty much the same way as the
missing '.alias' does.

[1] https://www.redhat.com/archives/libvir-list/2016-September/msg00386.html

Erik




More information about the libvir-list mailing list