[libvirt] [PATCH 11/41] qemu: Separate guest CPU validation from command line creation

[Jiri Denemark]

On Mon, Aug 29, 2016 at 15:21:43 -0400, John Ferlan wrote:
...
> > -    driver.caps->host.cpu->arch = VIR_ARCH_AARCH64;
> > +    qemuTestSetHostArch(driver.caps, VIR_ARCH_AARCH64);
> >      DO_TEST("aarch64-kvm-32-on-64",
> >              QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_DEVICE_VIRTIO_MMIO,
> >              QEMU_CAPS_KVM, QEMU_CAPS_CPU_AARCH64_OFF);
> >      DO_TEST_FAILURE("aarch64-kvm-32-on-64",
> >              QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_DEVICE_VIRTIO_MMIO,
> >              QEMU_CAPS_KVM);
> > -    driver.caps->host.cpu->arch = cpuDefault->arch;
> > +    qemuTestSetHostArch(driver.caps, VIR_ARCH_NONE);
> 
> Adding this one causes failure... Perhaps due to the:
> 
> +    if (cpu)
> +        caps->host.arch = cpu->arch;
> 
> in previous patch?  or perhaps some shortly subsequent patch...
> 
> It's not so much an objection to the patch, but by simply adding those
> API's in patch 10 I guess I would have expected them to just work, but
> trial and error proves otherwise. Of course reading future patches
> perhaps sheds even more light (or black magic, voodoo) ;-).

The test suite was heavily relying on bugs in our code, which means both
need to be fixed at the same time, otherwise the tests would just break.

Jirka