[libvirt] [PATCH 2/2] virDomainGetBlockJobInfo: Fix corner case when qemu reports no info
Michal Privoznik
mprivozn at redhat.com
Wed Sep 14 10:47:16 UTC 2016
On 13.09.2016 19:03, Eric Blake wrote:
> On 09/13/2016 06:02 AM, Michal Privoznik wrote:
>
>>> So, just to make it crystal clear, is this what you're saying?
>>>
>>> ready | initial C/R |fudged C/R
>>
>> Oh, This should have been C/E instead of C/R. Current/End. 'e' and 'r'
>> keys are just too close to each other :-)
>>
>>> ------+-------------+----------
>>> < 0 | 0/0 | 0/0
>>> = 0 | 0/0 | 0/1
>>> > 0 | 0/0 | 1/1
>
> Yes, I think that's the best. Then we have documented to apps higher in
> the stack that if they see 0/0, it is because qemu is too old to give us
> a definitive answer; in all other cases, we have fudged data so that
> higher layers don't have to worry about 0/0.
>
Thank you guys, I've pushed the patch then (with the behaviour as
described in the table).
Michal
More information about the libvir-list
mailing list