[libvirt] [PATCH 24/41] conf: Introduce virCPUDefMoveModel

Jiri Denemark jdenemar at redhat.com
Wed Sep 14 13:55:19 UTC 2016


On Tue, Aug 30, 2016 at 10:24:07 -0400, John Ferlan wrote:
> 
> 
> On 08/12/2016 09:33 AM, Jiri Denemark wrote:
> > The function moves CPU model related parts from one CPU definition to
> > another. It can be used to avoid unnecessary copies from a temporary CPU
> > definitions which will be freed anyway.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> >  src/conf/cpu_conf.c      | 17 +++++++++++++++++
> >  src/conf/cpu_conf.h      |  4 ++++
> >  src/libvirt_private.syms |  1 +
> >  3 files changed, 22 insertions(+)
> > 
> 
> Less "Move" and more "Take"... virCPUDefStealModel is a suggestion - of

Ok, works for me. Changed.

> course it's more than ->model, but close enough I think.

It's documented that it's more than just ->model. And actually all
*Model APIs work on more than just ->model.

Jirka




More information about the libvir-list mailing list