[libvirt] [PATCH 02/16] hyperv: add cim types support to code generator

[Matthias Bolte]

2016-09-14 23:16 GMT+02:00 John Ferlan <jferlan at redhat.com>:
>
>
> On 08/09/2016 08:39 AM, Jason Miesionczek wrote:
>> ---
>>  src/hyperv/hyperv_wmi_generator.py | 57 ++++++++++++++++++++++++++++++++++++--
>>  1 file changed, 54 insertions(+), 3 deletions(-)
>>
>
> Not that familiar with the needs here. I assume it's fine, but your
> commit message should describe what's going on.  As in what these
> changes do.
>
> John

Actually I'd drop this patch. It basically builds up a string lookup
table to be used in patch 7 at runtime. I don't think that that is the
right approach for this.

John, thanks for looking at these patches.

-- 
Matthias Bolte
http://photron.blogspot.com