[libvirt] [PATCH 2/3] docs/Makefile.am: build hvsupport.html earlier

Andrea Bolognani abologna at redhat.com
Thu Sep 15 14:10:28 UTC 2016


On Wed, 2016-08-03 at 18:30 +0200, Ján Tomko wrote:
> This file requires three steps instead of two.

Did you mean "two steps instead of one"?

AFAICT it goes

  hvsupport.pl → hvsupport.html.in → hvsupport.html

as opposed to eg.

  drvqemu.html.in → drvqemu.html

> Move it earlier in the list of targets to avoid waiting for it.

This might warrant a comment in Makefile.am, just to make sure
the list will not be shuffled around again in the future.

> ---
>  docs/Makefile.am | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/Makefile.am b/docs/Makefile.am
> index f266117..d6e975d 100644
> --- a/docs/Makefile.am
> +++ b/docs/Makefile.am
> @@ -96,9 +96,10 @@ internals_html = $(internals_html_in:%.html.in=%.html)
>  # For all other files, since we ship pre-built html in the
>  # tarball, we must also ship the sources, even when those
>  # sources are themselves generated.
> -dot_html_in = $(notdir $(wildcard $(srcdir)/*.html.in)) \
> +dot_html_in = \
> +  hvsupport.html.in \
>    todo.html.in \
> -  hvsupport.html.in
> +  $(notdir $(wildcard $(srcdir)/*.html.in))
>  dot_html = $(dot_html_in:%.html.in=%.html)
>  
>  dot_php_in = $(notdir $(wildcard $(srcdir)/*.php.in))

ACK

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list