[libvirt] [PATCH 10/20] qemu: Disable migration for shmem with peer role

Martin Kletzander mkletzan at redhat.com
Thu Sep 15 16:14:35 UTC 2016


Such migration wouldn't work anyway with QEMU, we just haven't checked
for it before.

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 src/qemu/qemu_migration.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index e734816c4e12..d29b52b7aefa 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2346,6 +2346,19 @@ qemuMigrationIsAllowed(virQEMUDriverPtr driver,
                 return false;
             }
         }
+
+        for (i = 0; i < vm->def->nshmems; i++) {
+            virDomainShmemDefPtr shmem = vm->def->shmems[i];
+
+            if (shmem->role != VIR_DOMAIN_SHMEM_ROLE_MASTER) {
+                virReportError(VIR_ERR_OPERATION_INVALID,
+                               _("domain's shmem device '%s' has role='%s', "
+                                 "try unplugging it first"),
+                               shmem->name,
+                               virDomainShmemRoleTypeToString(shmem->role));
+                return false;
+            }
+        }
     }

     return true;
-- 
2.10.0




More information about the libvir-list mailing list