[libvirt] [PATCH] test driver: File test_driver.c was splitted into smaller files.
Daniel P. Berrange
berrange at redhat.com
Fri Sep 16 13:30:17 UTC 2016
On Fri, Sep 16, 2016 at 03:06:27PM +0200, Tomáš Ryšavý wrote:
> Because the file had over 7000 lines. Now its splitted into 5
> smaller files. It looks clearer and it's better for reading the code.
>
> Signed-off-by: Tomáš Ryšavý <tom.rysavy.0 at gmail.com>
> ---
> po/POTFILES.in | 6 +-
> src/Makefile.am | 8 +-
> src/test/test_device_driver.c | 462 +++
> src/test/test_device_driver.h | 1 +
> src/test/test_driver.c | 6924 +------------------------------------
> src/test/test_hypervisor_driver.c | 4152 ++++++++++++++++++++++
> src/test/test_hypervisor_driver.h | 1 +
> src/test/test_interface_driver.c | 487 +++
> src/test/test_interface_driver.h | 1 +
> src/test/test_network_driver.c | 540 +++
> src/test/test_network_driver.h | 1 +
> src/test/test_private_driver.h | 70 +
> src/test/test_storage_driver.c | 1517 ++++++++
> src/test/test_storage_driver.h | 1 +
> 14 files changed, 7259 insertions(+), 6912 deletions(-)
> create mode 100644 src/test/test_device_driver.c
> create mode 100644 src/test/test_device_driver.h
> create mode 100644 src/test/test_hypervisor_driver.c
> create mode 100644 src/test/test_hypervisor_driver.h
> create mode 100644 src/test/test_interface_driver.c
> create mode 100644 src/test/test_interface_driver.h
> create mode 100644 src/test/test_network_driver.c
> create mode 100644 src/test/test_network_driver.h
> create mode 100644 src/test/test_private_driver.h
> create mode 100644 src/test/test_storage_driver.c
> create mode 100644 src/test/test_storage_driver.h
Doing this is all in one patch is *way* too much change at
once.
Please split this into at least 4 patches, one for each new new .c
file you create.
Arguably it could be done across 8 patches. The first 4 patches would
create each of the new .h files, removing 'static' from the method
impls. The second 4 would then move the impls.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list