[libvirt] [PATCH 07/20] qemu: Add newer shmem models

[Martin Kletzander]

On Fri, Sep 16, 2016 at 09:48:12AM +0200, Peter Krempa wrote:
>On Thu, Sep 15, 2016 at 18:14:32 +0200, Martin Kletzander wrote:
>> The old ivshmem is deprecated in QEMU, so let's use the better
>> ivshmem-{plain,doorbell} variants instead.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  docs/schemas/domaincommon.rng | 2 ++
>>  src/conf/domain_conf.c        | 4 +++-
>>  src/conf/domain_conf.h        | 2 ++
>>  src/qemu/qemu_command.c       | 7 +++++++
>>  4 files changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
>> index fd7d52d72515..9827d6511781 100644
>> --- a/docs/schemas/domaincommon.rng
>> +++ b/docs/schemas/domaincommon.rng
>> @@ -3598,6 +3598,8 @@
>>              <attribute name="type">
>>                <choice>
>>                  <value>ivshmem</value>
>> +                <value>ivshmem-plain</value>
>> +                <value>ivshmem-doorbell</value>
>
>I don't really like the qemu naming here but I don't have any better
>idea.
>

I kinda wanted to do ivshmem-modern (and not split it between -plain and
-doorbell), but "modern" is one of the worst naming options, the only
worse one I can think of is ivshmem-new...  So I left it this way.

>>                </choice>
>>              </attribute>
>>            </element>
>
>Also note that using the new device models when migrating to older
>libvirt will break at the migration phase since older libvirt did not
>parse the model. Not sure whether it's worth worrying about though since
>this won't be used very much.
>
>Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160916/ae842e2c/attachment-0001.sig>