[libvirt] [PATCH] hyperv: add new WMI classes and improve generator

[Matthias Bolte]

2016-09-16 18:35 GMT+02:00 Jason Miesionczek <jmiesionczek at datto.com>:
> ---
>  src/hyperv/hyperv_wmi_generator.input | 485 ++++++++++++++++++++++++++++++++++
>  src/hyperv/hyperv_wmi_generator.py    |  57 +++-
>  2 files changed, 539 insertions(+), 3 deletions(-)
>

I've already pushed a cleanup version of your first patch from the
previous series yesterday. Along with some parts from the second patch
to make it self-contained.

Also you still have the code in here to generate the 2-level string
lookup table for the parameter types. As I explained in my response to
patch 7, I think the string based lookup inefficient and unnecessary.

The generator has all the information to make this a 2-level index based lookup.

Therefore, NACK.

-- 
Matthias Bolte
http://photron.blogspot.com