[libvirt] [PATCH v3 1/2] qemu/gluster: add option for tuning debug logging level
Peter Krempa
pkrempa at redhat.com
Tue Sep 20 10:11:15 UTC 2016
On Tue, Sep 20, 2016 at 15:23:03 +0530, Prasanna Kumar Kalever wrote:
> This helps in selecting log level of the gluster gfapi, output to stderr.
> The option is 'gluster_debug_level', can be tuned by editing
> '/etc/libvirt/qemu.conf'
>
> Debug levels ranges 0-9, with 9 being the most verbose, and 0 representing
> no debugging output. The default is the same as it was before, which
> is a level of 4. The current logging levels defined in the gluster
> gfapi are:
>
> 0 - None
> 1 - Emergency
> 2 - Alert
> 3 - Critical
> 4 - Error
> 5 - Warning
> 6 - Notice
> 7 - Info
> 8 - Debug
> 9 - Trace
>
> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever at redhat.com>
> ---
> src/qemu/libvirtd_qemu.aug | 3 +++
> src/qemu/qemu.conf | 20 ++++++++++++++++++++
> src/qemu/qemu_command.c | 14 +++++++++++++-
> src/qemu/qemu_conf.c | 3 +++
> src/qemu/qemu_conf.h | 1 +
> src/util/virstoragefile.h | 2 ++
> .../qemuargv2xml-disk-drive-network-gluster.args | 7 ++++---
> .../qemuxml2argv-disk-drive-network-gluster.args | 12 ++++++------
> 8 files changed, 52 insertions(+), 10 deletions(-)
>
> diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug
> index 988201e..bdeaeef 100644
> --- a/src/qemu/libvirtd_qemu.aug
> +++ b/src/qemu/libvirtd_qemu.aug
> @@ -104,6 +104,8 @@ module Libvirtd_qemu =
>
> let nvram_entry = str_array_entry "nvram"
>
> + let debug = int_entry "gluster_debug_level"
This is a too common name.
> +
> (* Each entry in the config is one of the following ... *)
> let entry = default_tls_entry
> | vnc_entry
> @@ -119,6 +121,7 @@ module Libvirtd_qemu =
> | network_entry
> | log_entry
> | nvram_entry
> + | debug
>
> let comment = [ label "#comment" . del /#[ \t]*/ "# " . store /([^ \t\n][^\n]*)?/ . del /\n/ "\n" ]
> let empty = [ label "#empty" . eol ]
The rest looks now good to me. Since the second patch has too many
problems you can respin the name as well.
Peter
More information about the libvir-list
mailing list