[libvirt] [PATCH] qemu: Ignore graphics cookie if port == 0

[Jiri Denemark]

On Wed, Sep 21, 2016 at 13:54:47 +0200, Michal Privoznik wrote:
> On 21.09.2016 10:04, Jiri Denemark wrote:
> > Old libvirt represents
> > 
> >     <graphics type='spice'>
> >       <listen type='none'/>
> >     </graphics>
> > 
> > as
> > 
> >     <graphics type='spice' autoport='no'/>
> > 
> > In this mode, QEMU doesn't listen for SPICE connection anywhere and
> > clients have to use virDomainOpenGraphics* APIs to attach to the domain.
> > That is, the client has to run on the same host where the domains runs
> > and it's impossible to tell the client to reconnect to the destination
> > QEMU during migration (unless there is some kind of proxy on the host).
> > 
> > While current libvirt correctly ignores such graphics devices when
> > creating graphics migration cookie, old libvirt just sends
> > 
> >     <graphics type='spice' port='0' listen='0.0.0.0' tlsPort='-1'/>
> > 
> > in the cookie. After seeing this cookie, we happily would call
> > client_migrate_info QMP command and wait for SPICE_MIGRATE_COMPLETED
> > event, which is quite pointless since the doesn't know where to connecti
> > anyway. We should just ignore such cookies.
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1376083
> > 
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> 
> ACK

Pushed, thanks.

Jirka