[libvirt] [PATCH 0/4] qemu: fix vcpupin/emulatorpin with --config on VMs with automatic NUMA pinning

Michal Privoznik mprivozn at redhat.com
Wed Sep 21 14:50:52 UTC 2016


On 21.09.2016 15:54, Martin Kletzander wrote:
> On Wed, Sep 14, 2016 at 08:39:05AM +0200, Peter Krempa wrote:
>> The automatic nodeset would creep into the persistent definition for
>> live VMs
>> with automatic pinning which is incorrect.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1365779
>>
>> Peter Krempa (4):
>>  conf: Introduce virDomainObjGetOneDefState
>>  qemu: domain: Add macro to simplify access to vm private data
> 
> I must say I don't like this one ^^, it's way more readable to just use
> the variable which can be just optimized out, but since we use that
> already in multiple places, meh ACK series, I guess.

Agreed. It makes debugging way worse and also does not work well with
autocomplete in my vim. Revert it please.

Michal




More information about the libvir-list mailing list