[libvirt] [PATCH v2 0/3] pass the path of compress prog directly
Chen Hanxiao
chen_han_xiao at 126.com
Thu Sep 22 01:45:58 UTC 2016
At 2016-09-22 05:32:10, "John Ferlan" <jferlan at redhat.com> wrote:
>
>
>On 09/19/2016 07:06 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao at gmail.com>
>>
>> This series will pass the path of compress programe
>> directly to functions such as doCoreDump, qemuDomainSaveInternal, etc.
>> this can avoid one extra virFindFileInPath call in during virExec.
>>
>> Also reduce code duplication by macros.
>>
>> Chen Hanxiao (3):
>> qemu_driver: pass path of compress prog directly
>> qemu_driver: simplify compress prog check by macros
>> qemu_driver: pass path of compress prog directly to doCoreDump
>>
>> src/qemu/qemu_driver.c | 242 ++++++++++++++++++++++++++-----------------------
>> 1 file changed, 128 insertions(+), 114 deletions(-)
>>
>
>
>Not really what I had in mind.
>
>I've posted a different approach instead. See
>
>http://www.redhat.com/archives/libvir-list/2016-September/msg00971.html
I'll review your series as soon as possible.
>
>BTW: Patch 2 fails syntax-check
>
I make syntax-check again and passed on a centos7 machine.
Maybe it's a syntax-check bug?
Regards,
- Chen
More information about the libvir-list
mailing list