[libvirt] [PATCH 5/8] qemuhelptest: regenerate data for qemu-1.2.0

[Pavel Hrdina]

On Fri, Sep 23, 2016 at 10:22:51AM +0200, Martin Kletzander wrote:
> On Fri, Sep 23, 2016 at 09:43:53AM +0200, Pavel Hrdina wrote:
> >On Fri, Sep 23, 2016 at 08:38:01AM +0200, Martin Kletzander wrote:
> >> On Thu, Sep 22, 2016 at 05:08:57PM +0200, Pavel Hrdina wrote:
> >> >This patch also removes device data for qemu-1.2.0 as it was removed for
> >> >qemu-kvm-1.2.0 by commit ae3e29e6e.  They are not required because we
> >> >parse only version from help output and return with error that this qemu
> >> >is too new to use help parsing.
> >> >
> >> >Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> >> >---
> >> > tests/qemuhelpdata/qemu-1.2.0        |   1 +
> >>
> >> You should also remove this file ^^ and fix testHelpStrParsing() not to
> >> load it if expecting error (and basically not being used).
> >
> >The thing with virQEMUCapsParseHelpStr() is that it parses qemu version
> >from the help output so to make the test meaningful we need to provide
> >output of "qemu -help".  This tests the code that reject to parse help if
> >qemu is too new.
> >
> 
> Well, we could then provide just that one line if we're cleaning up some
> stuff.  But I don't have a huge preference for that.  We'll hopefully

That was out of scope of "qemu-system-x86_64 --help > qemu-1.2.0" :).

Thanks, I'll push it shortly.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160923/1348ae8e/attachment-0001.sig>