[libvirt] [PATCH v2 0/8] Pass the path of compress program (redo)

John Ferlan jferlan at redhat.com
Fri Sep 23 11:30:48 UTC 2016


v1: http://www.redhat.com/archives/libvir-list/2016-September/msg00971.html

Changes in v2:

 1. Create a patch 5 which alters the qemuGetCompressionProgram to take a
    new const char * parameter which will be used in the warning message
    as the %s image format "style" (dump, save, snapshot) for both messages.
    Also removed the unnecessary translated message marker _() for the
    VIR_WARN message.
 
 2. Alter former patch 5 to pass the style ("save" or "snapshot") as an
    argument for the altered virReportError messages which now will take
    a parameter that describe their style. For one message it keeps it
    constant, for the other it adds the style into the message.

 3. Alter former patches 6 and 7 to account for the new argument (no real
    changes, just handling merge conflicts).

(from patch 1's cover)

Rather than try to describe what I was thinking about for the passing
the compress program directly series from Chen Hanxiao:

http://www.redhat.com/archives/libvir-list/2016-September/msg00677.html

and

http://www.redhat.com/archives/libvir-list/2016-August/msg01237.html

I took the liberty of creating my own set of patches which should end
in the more or less same result.

The primary benefit is not calling virFileInPath twice since we already
get it at least once for the various compressed program callers, let's
pass what we originally found.


John Ferlan (8):
  qemu: Move getCompressionType
  qemu: Adjust doCoreDump to call getCompressionType
  qemu: Introduce helper qemuGetCompressionProgram
  qemu: Remove getCompressionType
  qemu: Alter qemuGetCompressionProgram warning message
  qemu: Use qemuGetCompressionProgram for error paths
  qemu: Remove qemuCompressProgramAvailable
  qemu: Get/return compressedpath program

 src/qemu/qemu_driver.c | 241 ++++++++++++++++++++++++-------------------------
 1 file changed, 117 insertions(+), 124 deletions(-)

-- 
2.7.4




More information about the libvir-list mailing list