[libvirt] [PATCH 3/9] qemuBuildChrChardevStr: Introduce @nowait argument

[Michal Privoznik]

On 23.09.2016 00:50, John Ferlan wrote:
> 
> 
> On 08/16/2016 11:41 AM, Michal Privoznik wrote:
>> This alone makes not much sense. But the aim is to reuse this
>> function in qemuBuildVhostuserCommandLine() where 'nowait' is not
>> supported for vhost-user devices.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>  src/qemu/qemu_command.c | 34 ++++++++++++++++++----------------
>>  1 file changed, 18 insertions(+), 16 deletions(-)
>>
> 
> This one had some merge conflicts with some changes I made - not
> difficult to handle thankfully... Of course it caused me to notice some
> bad indention in my code too <sigh>
> 
> These changes look fine to me though, with one question...
> 
> Considering my changes were to add the ability to use TLS for a TCP
> chardev via 'tls-creds' - how does that play with your next change to
> add a 'vhost-user' chardev option? OK beyond what will be some very
> obvious issues with usage of NULL parameters.

Yeah, I might need to rework this.

> 
> IOW: Does one of these vhost-user chardevs "support" that "tls-creds"
> option?
> 

Maybe. But I don't think it's used - the chardev sockets for vhost-user
are just a control interface and are used just locally. Therefore I
think TLS is not used here by anybody.

Michal