[libvirt] [libvirt-php][PATCH 00/14] Fix code styling in libvirt-php

Michal Privoznik mprivozn at redhat.com
Sat Sep 24 08:36:10 UTC 2016


On 23.09.2016 20:49, Katerina Koukiou wrote:
> Fixed some basic code styling issues in libvirt-php.c that made the code
> hard to read.
> 
> Katerina Koukiou (14):
>   libvirt-php.c: Fix coding style issues:     space required after ','
>   libvirt-php.c: Fix coding style issues:     spaces required around
>     '==', '>=', '<=' etc.
>   libvirt-php.c: Fix coding style issues:     space prohibited between
>     function name and open parenthesis '('
>   libvirt-php.c: Fix coding style issues:     remove unwanted spaces
>     after '(' and before ')'
>   libvirt-php.c: Fix code styling issues:     no space needed after '['
>     and before ']'
>   libvirt-php.c: Fix code styling issues:     if then else statement
>     style issues
>   libvirt-php.c: Fix coding style issues with braces
>   libvirt-php.c Fix coding style issues with if statements
>   libvirt-php.c: Fix coding style issues:     space required around '='
>     in assignments
>   libvirt-php.c: Fix code styling issues with for loops
>   libvirt-php.c: Fix coding style issues: "(foo*)" should be "(foo *)"
>   libvirt-php.c: Fix coding style issues with operators
>   libvirt-php.c: Fix coding style issues with extra/less spaces
>   libvirt-php.c: Fix coding style issues in macros
> 
>  src/libvirt-php.c | 2220 ++++++++++++++++++++++++++---------------------------
>  1 file changed, 1101 insertions(+), 1119 deletions(-)
> 

Hey, this is very awesome! Thank you for your patches. I reviewed them
(thank God for 'git diff -w'). I've tried to check if fixed all the
places, but it looks like you did (at least in some randomly picked
patches :-)). But then there are other files in our source tree which
suffer the same problems :-(

ACKed and pushed.

Michal




More information about the libvir-list mailing list